Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow modifying user email from settings #282

Merged
merged 5 commits into from
Dec 21, 2024

Conversation

ansen01-svg
Copy link
Contributor

What changed?

Added email display in settings account page.

Why?

Users were unable to view their current email, or update the email.

How was this change made?

Added email edit section to /settings/account page.

@github-actions github-actions bot added frontend CSS, HTML, and JS changes backend Schema, query, and mutation changes labels Dec 15, 2024
@evadecker evadecker self-requested a review December 15, 2024 21:43
@evadecker
Copy link
Member

Hey @ansen01-svg! I'll take a closer look at this soon. I appreciate you diving in here!

@evadecker evadecker changed the title feat: added email display in account settings page. feat: Allow modifying user email from settings Dec 15, 2024
Copy link
Member

@evadecker evadecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good so far @ansen01-svg! Would love to get some tests written for this.

.gitignore Outdated Show resolved Hide resolved
convex/_generated/api.d.ts Show resolved Hide resolved
convex/users.ts Outdated Show resolved Hide resolved
convex/users.ts Show resolved Hide resolved
src/components/settings/EditEmailSetting/index.tsx Outdated Show resolved Hide resolved
@evadecker evadecker added this to the Namesake v1.0 milestone Dec 17, 2024
Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: 90a8c42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
namesake Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added dependencies Pull requests that update a dependency file testing Unit and e2e tests labels Dec 20, 2024
Copy link
Member

@evadecker evadecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments, but otherwise this looks great! Thanks so much for adding the feature and tests. 🎉

@evadecker
Copy link
Member

If you pull the latest changes from main and run pnpm i it should resolve the conflicts in pnpm-lock.yaml.

@evadecker evadecker linked an issue Dec 21, 2024 that may be closed by this pull request
@evadecker evadecker self-requested a review December 21, 2024 05:56
Copy link
Member

@evadecker evadecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ansen01-svg! 🙌

@evadecker evadecker merged commit 6e76b6f into namesakefyi:main Dec 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Schema, query, and mutation changes dependencies Pull requests that update a dependency file frontend CSS, HTML, and JS changes testing Unit and e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support displaying and updating user email from within settings
2 participants