-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow modifying user email from settings #282
feat: Allow modifying user email from settings #282
Conversation
Hey @ansen01-svg! I'll take a closer look at this soon. I appreciate you diving in here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good so far @ansen01-svg! Would love to get some tests written for this.
🦋 Changeset detectedLatest commit: 90a8c42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small comments, but otherwise this looks great! Thanks so much for adding the feature and tests. 🎉
If you pull the latest changes from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @ansen01-svg! 🙌
What changed?
Added email display in settings account page.
Why?
Users were unable to view their current email, or update the email.
How was this change made?
Added email edit section to /settings/account page.